Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to dedicated AWS account and update CI #60

Merged
merged 5 commits into from
Feb 5, 2024
Merged

feat: migrate to dedicated AWS account and update CI #60

merged 5 commits into from
Feb 5, 2024

Conversation

xav
Copy link
Contributor

@xav xav commented Feb 2, 2024

Description

Migrate to the dedicated AWS account and switch CI to the shared flows

Resolves # (issue)

How Has This Been Tested?

Deployed manually

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@xav xav linked an issue Feb 2, 2024 that may be closed by this pull request
Migrate to dedicated AWS account #58
Closed
@xav xav force-pushed the 58-migrate-ti-dedicated-aws-account branch from dfa1c6f to ec0dfbc Compare February 2, 2024 14:32
@xav xav force-pushed the 58-migrate-ti-dedicated-aws-account branch from e0e253c to 2e4afff Compare February 2, 2024 15:39
@xav xav force-pushed the 58-migrate-ti-dedicated-aws-account branch from 2e4afff to 887199b Compare February 2, 2024 15:52
@xav xav requested review from xDarksome and arein and removed request for xDarksome February 4, 2024 17:38
arein
arein approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just out of extra caution: please add on statuspage and let's confirm metrics/alarms afterwards

xDarksome
xDarksome approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@xDarksome xDarksome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming:

  • CI/CD actions are tested
  • integration tests pass
  • analytics export works

.github/workflows/debug_validate.yml Outdated Show resolved Hide resolved
@xav xav merged commit ab057bb into main Feb 5, 2024
15 checks passed
@xav xav deleted the 58-migrate-ti-dedicated-aws-account branch February 5, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arein arein arein approved these changes

@xDarksome xDarksome xDarksome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to dedicated AWS account
3 participants
@xav @arein @xDarksome